eslint: run via npx #2795
Draft
eslint: run via npx #2795
+10
−1,258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
reviewed
Jun 28, 2024
Comment on lines
-8
to
-11
| "eslint-plugin-import": "^2.22.1", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-promise": "^4.2.1", | ||
| "eslint-plugin-standard": "^5.0.0" |
There was a problem hiding this comment.
I'm not sure running npx eslint would have any way of knowing about these plugin dependencies anymore
There was a problem hiding this comment.
We can enable them individually (and I initially did --package a --package b ...), however, I couldn't seem to find any functional difference from removing them?
There was a problem hiding this comment.
Would have to add a violation to one of the rules supplied by one of these plugins to see any difference
There was a problem hiding this comment.
That is what I tried yes.
There was a problem hiding this comment.
In the latest run
ESLint couldn't find the config "standard" to extend from.
MetRonnie
reviewed
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really don't need to maintain an eslint lock file, we just need a vaguely up-to-date version.